Stabilize feature char_indices_offset by eduardosm · Pull Request #129276 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
bors merged 1 commit intorust-lang:masterfromeduardosm:stabilize-char_indices_offset
Aug 23, 2024
Conversation3 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Stabilized API:
impl CharIndices<'_> { pub fn offset(&self) -> usize; }
Tracking issue: #83871
Closes #83871
I also attempted to improved the documentation to make it more clear that it returns the offset of the character that will be returned by the next call to next().
r? @Amanieu
rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library team, which will review and decide on the PR/issue.
labels
📌 Commit dbad758 has been approved by Amanieu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
tgross35 added a commit to tgross35/rust that referenced this pull request
…ffset, r=Amanieu
Stabilize feature char_indices_offset
Stabilized API:
impl CharIndices<'_> {
pub fn offset(&self) -> usize;
}Tracking issue: rust-lang#83871
Closes rust-lang#83871
I also attempted to improved the documentation to make it more clear that it returns the offset of the character that will be returned by the next call to next().
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 7 pull requests
Successful merges:
- rust-lang#128192 (rustc_target: Add various aarch64 features)
- rust-lang#128507 (Migrate
libtest-thread-limitrun-maketest to rmake) - rust-lang#129190 (Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs)
- rust-lang#129276 (Stabilize feature
char_indices_offset) - rust-lang#129350 (adapt integer comparison tests for LLVM 20 IR changes)
- rust-lang#129414 (Fix extern crates not being hidden with
doc(hidden)) - rust-lang#129426 (rustdoc-search: use tighter json for names and parents)
r? @ghost
@rustbot modify labels: rollup
tgross35 added a commit to tgross35/rust that referenced this pull request
…ffset, r=Amanieu
Stabilize feature char_indices_offset
Stabilized API:
impl CharIndices<'_> {
pub fn offset(&self) -> usize;
}Tracking issue: rust-lang#83871
Closes rust-lang#83871
I also attempted to improved the documentation to make it more clear that it returns the offset of the character that will be returned by the next call to next().
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 7 pull requests
Successful merges:
- rust-lang#126985 (Implement
-Z embed-source(DWARFv5 source code embedding extension)) - rust-lang#128349 (Enable
f16tests on x86 and x86-64) - rust-lang#128511 (Document WebAssembly target feature expectations)
- rust-lang#129263 (Add a missing compatibility note in the 1.80.0 release notes)
- rust-lang#129276 (Stabilize feature
char_indices_offset) - rust-lang#129350 (adapt integer comparison tests for LLVM 20 IR changes)
- rust-lang#129408 (Fix handling of macro arguments within the
dropping_copy_typeslint)
r? @ghost
@rustbot modify labels: rollup
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
…ffset, r=Amanieu
Stabilize feature char_indices_offset
Stabilized API:
impl CharIndices<'_> {
pub fn offset(&self) -> usize;
}Tracking issue: rust-lang#83871
Closes rust-lang#83871
I also attempted to improved the documentation to make it more clear that it returns the offset of the character that will be returned by the next call to next().
This was referenced
Aug 23, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request
…llaumeGomez
Rollup of 9 pull requests
Successful merges:
- rust-lang#128511 (Document WebAssembly target feature expectations)
- rust-lang#129243 (do not build
cargo-miriby default on stable channel) - rust-lang#129263 (Add a missing compatibility note in the 1.80.0 release notes)
- rust-lang#129276 (Stabilize feature
char_indices_offset) - rust-lang#129350 (adapt integer comparison tests for LLVM 20 IR changes)
- rust-lang#129408 (Fix handling of macro arguments within the
dropping_copy_typeslint) - rust-lang#129426 (rustdoc-search: use tighter json for names and parents)
- rust-lang#129437 (Fix typo in a help diagnostic)
- rust-lang#129457 (kobzol vacation)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#129276 - eduardosm:stabilize-char_indices_offset, r=Amanieu
Stabilize feature char_indices_offset
Stabilized API:
impl CharIndices<'_> {
pub fn offset(&self) -> usize;
}Tracking issue: rust-lang#83871
Closes rust-lang#83871
I also attempted to improved the documentation to make it more clear that it returns the offset of the character that will be returned by the next call to next().
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the library team, which will review and decide on the PR/issue.