Add implementations for unbounded_shl/unbounded_shr by chorman0773 · Pull Request #129377 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation28 Commits8 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Tracking Issue: #129375
This implements unbounded_shl and unbounded_shr under the feature gate unbounded_shifts
r? @scottmcm
rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library team, which will review and decide on the PR/issue.
labels
feat(core): Add implementations for Add implementations for unbounded_shl/unbounded_shrunbounded_shl/unbounded_shr
This comment has been minimized.
This comment has been minimized.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if github will hide it, since it looks like I raced with one of your updates, but I have a suggestion in #129377
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
This comment has been minimized.
This comment has been minimized.
…nded_shr/unbounded_shl`
This comment has been minimized.
This comment has been minimized.
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Also, don't know whether I need to do this now, but rustc-dev-guide apparently wants this for new rustc_allow_const_fn_unstable uses, so CC: @rust-lang/wg-const-eval.
…c_allow_const_fn_unstable`
Thanks! I'm glad to have these, since I think they're the only good shifts :)
@bors r+ rollup
📌 Commit f4dc783 has been approved by scottmcm
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#129190 (Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs)
- rust-lang#129377 (Add implementations for
unbounded_shl/unbounded_shr) - rust-lang#129539 (link to Future::poll from the Poll docs)
- rust-lang#129588 (pal/hermit: correctly round up microseconds in
Thread::sleep) - rust-lang#129592 (Remove cfg(test) from library/core)
- rust-lang#129597 (mv
build_reduced_graph_for_external_crate_resinto Resolver) - rust-lang#129600 (Tie
impl_trait_overcaptureslint to Rust 2024)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#129190 (Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs)
- rust-lang#129377 (Add implementations for
unbounded_shl/unbounded_shr) - rust-lang#129539 (link to Future::poll from the Poll docs)
- rust-lang#129588 (pal/hermit: correctly round up microseconds in
Thread::sleep) - rust-lang#129592 (Remove cfg(test) from library/core)
- rust-lang#129597 (mv
build_reduced_graph_for_external_crate_resinto Resolver) - rust-lang#129600 (Tie
impl_trait_overcaptureslint to Rust 2024)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#129377 - chorman0773:unbounded-shifts-impl, r=scottmcm
Add implementations for unbounded_shl/unbounded_shr
Tracking Issue: rust-lang#129375
This implements unbounded_shl and unbounded_shr under the feature gate unbounded_shifts
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the library team, which will review and decide on the PR/issue.