Don't attempt to export compiler-builtins symbols from rust dylibs by bjorn3 · Pull Request #137736 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation18 Commits2 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

They are marked with hidden visibility to prevent them from getting exported, so we shouldn't ask the linker to export them anyway. The only thing that does it cause a warning on macOS.

Part of #136096

cc @jyn514

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added A-attributes

Area: Attributes (`#[…]`, `#![…]`)

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Feb 27, 2025

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Could not assign reviewer from: bjorn3.
User(s) bjorn3 are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

📌 Commit d73479e has been approved by petrochenkov

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Mar 13, 2025

jhpratt added a commit to jhpratt/rust that referenced this pull request

Mar 14, 2025

…x, r=petrochenkov

Don't attempt to export compiler-builtins symbols from rust dylibs

They are marked with hidden visibility to prevent them from getting exported, so we shouldn't ask the linker to export them anyway. The only thing that does it cause a warning on macOS.

Part of rust-lang#136096

cc @jyn514

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 14, 2025

Rollup of 6 pull requests

Successful merges:

• rust-lang#134720 (Display valid crate types in error message for --crate-type flag)
• rust-lang#137424 (uefi: helpers: Add DevicePathNode abstractions)
• rust-lang#137736 (Don't attempt to export compiler-builtins symbols from rust dylibs)
• rust-lang#138451 (Build GCC on CI with GCC, not Clang)
• rust-lang#138454 (Improve post-merge workflow)
• rust-lang#138477 (Deny impls for BikeshedGuaranteedNoDrop)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 14, 2025

… r=petrochenkov

Don't attempt to export compiler-builtins symbols from rust dylibs

They are marked with hidden visibility to prevent them from getting exported, so we shouldn't ask the linker to export them anyway. The only thing that does it cause a warning on macOS.

Part of rust-lang#136096

cc @jyn514

This comment has been minimized.

This comment was marked as resolved.

bors added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Mar 14, 2025

They are marked with hidden visibility to prevent them from getting exported, so we shouldn't ask the linker to export them anyway. The only thing that does it cause a warning on macOS.

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Otherwise the linker complains about EC symbols missing when compiling for arm64ec.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 21, 2025

… r=

Don't attempt to export compiler-builtins symbols from rust dylibs

They are marked with hidden visibility to prevent them from getting exported, so we shouldn't ask the linker to export them anyway. The only thing that does it cause a warning on macOS.

Part of rust-lang#136096

cc @jyn514

try-job: dist-aarch64-msvc

☀️ Try build successful - checks-actions
Build commit: c49fce8 (c49fce8bb237fee5ec3d8a6289ef774115fbc66f)

Looks like that did the trick.

@rustbot ready

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Mar 21, 2025

📌 Commit 530ab61 has been approved by petrochenkov

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Mar 21, 2025

tgross35 added a commit to tgross35/rust that referenced this pull request

Mar 22, 2025

…x, r=petrochenkov

Don't attempt to export compiler-builtins symbols from rust dylibs

They are marked with hidden visibility to prevent them from getting exported, so we shouldn't ask the linker to export them anyway. The only thing that does it cause a warning on macOS.

Part of rust-lang#136096

cc @jyn514

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 22, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 24, 2025

Rollup of 10 pull requests

Successful merges:

• rust-lang#137593 (fix download-llvm logic for subtree sync branches)
• rust-lang#137736 (Don't attempt to export compiler-builtins symbols from rust dylibs)
• rust-lang#138135 (Simplify PartialOrd on tuples containing primitives)
• rust-lang#138321 ([bootstrap] Distribute split debuginfo if present)
• rust-lang#138574 (rustdoc: be more strict about "Methods from Deref")
• rust-lang#138606 (Fix missing rustfmt in msi installer - cont)
• rust-lang#138671 (Fix FileType PartialEq implementation on Windows)
• rust-lang#138728 (Update compiler-builtins to 0.1.152)
• rust-lang#138783 (Cache current_dll_path output)
• rust-lang#138846 (Tweaks to writeback and Obligation -> Goal conversion)

Failed merges:

• rust-lang#138755 ([rustdoc] Remove duplicated loop when computing doc cfgs)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Mar 24, 2025

Rollup merge of rust-lang#137736 - bjorn3:compiler_builtins_export_fix, r=petrochenkov

Don't attempt to export compiler-builtins symbols from rust dylibs

They are marked with hidden visibility to prevent them from getting exported, so we shouldn't ask the linker to export them anyway. The only thing that does it cause a warning on macOS.

Part of rust-lang#136096

cc @jyn514

bjorn3 deleted the compiler_builtins_export_fix branch

March 24, 2025 10:16

Labels

A-attributes

Area: Attributes (`#[…]`, `#![…]`)

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.