Cache current_dll_path output by bjorn3 · Pull Request #138783 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Computing the current dll path is somewhat expensive relative to other work when compiling fn main() {} as dladdr needs to iterate over the symbol table of librustc_driver.so until it finds a match.
r? @SparrowLii
rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
This comment has been minimized.
Computing the current dll path is somewhat expensive relative to other
work when compiling fn main() {} as dladdr needs to iterate over the
symbol table of librustc_driver.so until it finds a match.
I don't think we'd need to check rustc-perf here, and if not, this makes sense and looks good, r=me.
📌 Commit 521d0c4 has been approved by lqd
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 10 pull requests
Successful merges:
- rust-lang#137593 (fix download-llvm logic for subtree sync branches)
- rust-lang#137736 (Don't attempt to export compiler-builtins symbols from rust dylibs)
- rust-lang#138135 (Simplify
PartialOrdon tuples containing primitives) - rust-lang#138321 ([bootstrap] Distribute split debuginfo if present)
- rust-lang#138574 (rustdoc: be more strict about "Methods from Deref")
- rust-lang#138606 (Fix missing rustfmt in msi installer - cont)
- rust-lang#138671 (Fix
FileTypePartialEqimplementation on Windows) - rust-lang#138728 (Update
compiler-builtinsto 0.1.152) - rust-lang#138783 (Cache current_dll_path output)
- rust-lang#138846 (Tweaks to writeback and
Obligation -> Goalconversion)
Failed merges:
- rust-lang#138755 ([rustdoc] Remove duplicated loop when computing doc cfgs)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#138783 - bjorn3:cache_current_dll_path, r=lqd
Cache current_dll_path output
Computing the current dll path is somewhat expensive relative to other work when compiling fn main() {} as dladdr needs to iterate over the symbol table of librustc_driver.so until it finds a match.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.