rustdoc: be more strict about "Methods from Deref" by lolbinarycat · Pull Request #138574 · rust-lang/rust (original) (raw)

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-rustdoc

Relevant to the rustdoc team, which will review and decide on the PR/issue.

T-rustdoc-frontend

Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

labels

Mar 16, 2025

This comment has been minimized.

pub fn get_u32(&self) -> u32 { self.0 }
}

// Note that the same href is used both on the method itself,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it an issue?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, since we're testing that it appears twice, and in any case, we care about the negative case much more, which will trigger if the bad method shows up in the sidebar or on the main page.

This comment has been minimized.

Thanks for the fix! Squash your commits then r=me.

hack: is_doc_subtype_of always returns true for TyAlias

it's worth noting that this function is only used in the handling of "Methods from Deref", and we were previously assuming all generic parameters were meaningless, so this is still an improvment from the status quo.

this change means that we will have strictly less false positives without adding any new false negitives.

Co-authored-by: Guillaume Gomez guillaume1.gomez@gmail.com

r=@GuillaumeGomez

(still don't have bors perms so I doubt the r= is going to do anything)

📌 Commit b46412f has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Mar 22, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 24, 2025

Rollup of 10 pull requests

Successful merges:

rust-lang#137593 (fix download-llvm logic for subtree sync branches)
rust-lang#137736 (Don't attempt to export compiler-builtins symbols from rust dylibs)
rust-lang#138135 (Simplify PartialOrd on tuples containing primitives)
rust-lang#138321 ([bootstrap] Distribute split debuginfo if present)
rust-lang#138574 (rustdoc: be more strict about "Methods from Deref")
rust-lang#138606 (Fix missing rustfmt in msi installer - cont)
rust-lang#138671 (Fix FileType PartialEq implementation on Windows)
rust-lang#138728 (Update compiler-builtins to 0.1.152)
rust-lang#138783 (Cache current_dll_path output)
rust-lang#138846 (Tweaks to writeback and Obligation -> Goal conversion)

Failed merges:

rust-lang#138755 ([rustdoc] Remove duplicated loop when computing doc cfgs)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Mar 24, 2025

Rollup merge of rust-lang#138574 - lolbinarycat:rustdoc-deref-24686-v2, r=GuillaumeGomez

rustdoc: be more strict about "Methods from Deref"

fixes rust-lang#137083 fixes rust-lang#24686

Currently done:

fix `render_assoc_items_inner
fix sidebar logic
port test from rust-lang#137564
add test for sidebar items

Note that this does not yet fix the sidebar logic.