Remove some unsized tuple impls now that we don't support unsizing tuples anymore by oli-obk · Pull Request #138340 · rust-lang/rust (original) (raw)
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Since #137728 there is no sound way to create unsized tuples anymore. While we can't remove them from the language (tried here: #138093) due to people using PhantomData<(T, U)> where U: ?Sized (they'd have to use (PhantomData<T>, PhantomData<U>) now), we can remove the impls from libcore I believe.
r? libs I guess?
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library team, which will review and decide on the PR/issue.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
Remove some unsized tuple impls now that we don't support unsizing tuples anymore
Since rust-lang#137728 there is no sound way to create unsized tuples anymore. While we can't remove them from the language due to people using PhantomData<(T, U)> where U: ?Sized (they'd have to use (PhantomData<T>, PhantomData<U>) now), we can remove the impls from libcore I believe.
r? ghost
☀️ Try build successful - checks-actions
Build commit: 0fe3684 (0fe3684930279e4d3be3aca66b30f82946ce9ac2)
🚧 Experiment pr-138340 is now running
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
The only regression is https://crates.io/crates/ord_subset/3.1.1 which was last updated 6 years ago. I'll check if I can contract the author, as there are a few crates depending on it
The author was unresponsive for a month, so moving ahead now.
Requesting libs-api since this will need FCP
r? libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
label
This change is insta-stable, so needs a completed FCP to proceed.
Nominated for discussion during a libs-api team meeting.
and removed T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:
No concerns currently listed.
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
In the final comment period and will be merged soon unless new substantive objections are raised.
label
🔔 This is now entering its final comment period, as per the review above. 🔔
The final comment period, with a disposition to merge, as per the review above, is now complete.
As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.
This will be merged soon.
Labels
This issue / PR is in PFCP or FCP with a disposition to merge it.
The final comment period is finished for this PR / Issue.
This change is insta-stable, so needs a completed FCP to proceed.
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library API team, which will review and decide on the PR/issue.
Announce this issue on triage meeting