Remove some glob imports from the type system by compiler-errors · Pull Request #142637 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation12 Commits2 Checks10 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Namely, remove the glob imports for BoundRegionConversionTime, RegionVariableOrigin, SubregionOrigin, TyOrConstInferVar, RegionResolutionError, SelectionError, ProjectionCandidate, ProjectionCandidateSet, and some more specific scoped globs (like Inserted in the impl overlap graph construction.

These glob imports are IMO very low value, since they're not used nearly as often as other globs (like TyKind).

r? @WaffleLapkin

rustbot has assigned @WaffleLapkin.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jun 17, 2025

Some changes occurred in need_type_info.rs

cc @lcnr

RegionInferReason::Param(def) => {
RegionVariableOrigin::RegionParameterDefinition(span, def.name)
}
_ => RegionVariableOrigin::MiscVariable(span),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that you're already modifying all uses of this variant, rename it to just Misc in this PR

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? @lcnr

r=me after nit + rebase

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

changes to the core type system

cc @compiler-errors, @lcnr

This comment has been minimized.

📌 Commit 9b07e2d has been approved by lcnr

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 19, 2025

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Jun 19, 2025

bors added a commit that referenced this pull request

Jun 19, 2025

Rollup of 3 pull requests

Successful merges:

#142478 (install docs for each target in different directory)
#142629 (Add config builder for bootstrap tests)
#142699 (Update books)

Failed merges:

#142637 (Remove some glob imports from the type system)

r? @ghost @rustbot modify labels: rollup

📌 Commit c995070 has been approved by lcnr

It is now in the queue for this repository.

bors removed the S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

label

Jun 26, 2025

bors added the S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

label

Jun 26, 2025

samueltardieu added a commit to samueltardieu/rust that referenced this pull request

Jun 26, 2025

Remove some glob imports from the type system

These glob imports are IMO very low value, since they're not used nearly as often as other globs (like TyKind).

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Jun 26, 2025

Remove some glob imports from the type system

These glob imports are IMO very low value, since they're not used nearly as often as other globs (like TyKind).

bors added a commit that referenced this pull request

Jun 26, 2025

Rollup of 17 pull requests

Successful merges:

#124595 (Suggest cloning Arc moved into closure)
#139594 (Simplify ObligationCauseCode::IfExpression)
#141311 (make tidy-alphabetical use a natural sort)
#141648 ([rustdoc] Do not emit redundant_explicit_links lint if the doc comment comes from expansion)
#142255 (Add edition checks for some tests that had divergent output)
#142285 (tests: Do not run afoul of asm.validity.non-exhaustive in input-stats)
#142549 (small iter.intersperse.fold() optimization)
#142637 (Remove some glob imports from the type system)
#142647 ([perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation)
#142700 (Remove incorrect comments in Weak)
#142884 (StableMIR: Add method to retrieve body of coroutine)
#142925 (Rewrite .gitattributes CRLF ui tests into run-make tests)
#143001 (Rename run always )
#143010 (Update browser-ui-test version to 0.20.7)
#143015 (Add sym::macro_pin diagnostic item for core::pin::pin!())
#143020 (codegen_fn_attrs: make comment more precise)
#143033 (Expand const-stabilized API links in relnotes)

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 26, 2025

Remove some glob imports from the type system

These glob imports are IMO very low value, since they're not used nearly as often as other globs (like TyKind).

compiler-errors added a commit to compiler-errors/rust that referenced this pull request

Jun 26, 2025

Remove some glob imports from the type system

These glob imports are IMO very low value, since they're not used nearly as often as other globs (like TyKind).

This was referenced

Jun 26, 2025

bors added a commit that referenced this pull request

Jun 27, 2025

…rors

Rollup of 18 pull requests

Successful merges:

#137843 (make RefCell unstably const)
#140942 (const-eval: allow constants to refer to mutable/external memory, but reject such constants as patterns)
#142549 (small iter.intersperse.fold() optimization)
#142637 (Remove some glob imports from the type system)
#142647 ([perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation)
#142700 (Remove incorrect comments in Weak)
#142927 (Add note to find_const_ty_from_env)
#142967 (Fix RwLock::try_write documentation for WouldBlock condition)
#142986 (Port #[export_name] to the new attribute parsing infrastructure)
#143001 (Rename run always )
#143010 (Update browser-ui-test version to 0.20.7)
#143015 (Add sym::macro_pin diagnostic item for core::pin::pin!())
#143033 (Expand const-stabilized API links in relnotes)
#143041 (Remove cache for citool)
#143056 (Move an ACE test out of the GCI directory)
#143059 (Fix 1.88 relnotes)
#143067 (Tracking issue number for iter_macro)
#143073 (Fix some fixmes that were waiting for let chains)

Failed merges:

#143020 (codegen_fn_attrs: make comment more precise)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit that referenced this pull request

Jun 27, 2025

Rollup merge of #142637 - compiler-errors:less-globs, r=lcnr

Remove some glob imports from the type system

These glob imports are IMO very low value, since they're not used nearly as often as other globs (like TyKind).

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Jul 4, 2025

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

WG-trait-system-refactor

The Rustc Trait System Refactor Initiative (-Znext-solver)