Rename run always by Shourya742 · Pull Request #143001 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation8 Commits1 Checks10 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

@Shourya742

This PR renames run_always to run_to_dry_run for better clarity, making the field's purpose more explicit and avoiding confusion with command caching behavior.

r? @Kobzol

@Shourya742

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Jun 25, 2025

@rustbot

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

jieyouxu

rustup.arg("--version");
rustup.allow_failure().run_always().run_capture_stdout(builder).is_success()
rustup.allow_failure().run_in_dry_run().run_capture_stdout(builder).is_success()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: run_wet

1000_F_194290026_tzTZYAloqGGGxHmoysGKFnWP570TtClc

ducks

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I just find run_in_dry_run a bit funny to read on a quick glance, but it does make sense)

@Kobzol

I guess we could call it "execute_in_dry_run", but that's quite long :) Yeah, the name is a bit funny, but it accurately describes what's going on, unlike the previous name (which would conflict with cached command execution - #142816).

You can r=me once CI is green.

@bors delegate+

@bors

✌️ @Shourya742, you can now approve this pull request!

If @Kobzol told you to "r=me" after making some further change, please make that change, then do @bors r=@Kobzol

@Shourya742

@bors

📌 Commit f908939 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 25, 2025

@Kobzol

SciMind2460 added a commit to SciMind2460/rust that referenced this pull request

Jun 25, 2025

@SciMind2460

…lways, r=Kobzol

Rename run always

This PR renames run_always to run_to_dry_run for better clarity, making the field's purpose more explicit and avoiding confusion with command caching behavior.

r? @Kobzol

samueltardieu added a commit to samueltardieu/rust that referenced this pull request

Jun 26, 2025

@samueltardieu

…lways, r=Kobzol

Rename run always

This PR renames run_always to run_to_dry_run for better clarity, making the field's purpose more explicit and avoiding confusion with command caching behavior.

r? @Kobzol

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Jun 26, 2025

@workingjubilee

…lways, r=Kobzol

Rename run always

This PR renames run_always to run_to_dry_run for better clarity, making the field's purpose more explicit and avoiding confusion with command caching behavior.

r? @Kobzol

bors added a commit that referenced this pull request

Jun 26, 2025

@bors

Rollup of 17 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 26, 2025

@matthiaskrgr

…lways, r=Kobzol

Rename run always

This PR renames run_always to run_to_dry_run for better clarity, making the field's purpose more explicit and avoiding confusion with command caching behavior.

r? @Kobzol

compiler-errors added a commit to compiler-errors/rust that referenced this pull request

Jun 26, 2025

@compiler-errors

…lways, r=Kobzol

Rename run always

This PR renames run_always to run_to_dry_run for better clarity, making the field's purpose more explicit and avoiding confusion with command caching behavior.

r? @Kobzol

This was referenced

Jun 26, 2025

bors added a commit that referenced this pull request

Jun 27, 2025

@bors

…rors

Rollup of 18 pull requests

Successful merges:

Failed merges:

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit that referenced this pull request

Jun 27, 2025

@rust-timer

Rollup merge of #143001 - Shourya742:2025-06-25-rename-run-always, r=Kobzol

Rename run always

This PR renames run_always to run_to_dry_run for better clarity, making the field's purpose more explicit and avoiding confusion with command caching behavior.

r? @Kobzol

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Jul 4, 2025

@bors

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)