Port #[export_name] to the new attribute parsing infrastructure by JonathanBrouwer · Pull Request #142986 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation24 Commits2 Checks10 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This PR contains two changes, in separate commits for reviewability:
- Ports
export_nameto the new attribute parsing infrastructure for Tracking issue: Attribute refactor #131229 (comment) - Moves the check for mixing export_name/no_mangle to check_attr.rs and improve the error message, which previously had a mix of 2021/2024 edition syntax
jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.
Area: Attributes (`#[…]`, `#![…]`)
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Some changes occurred in compiler/rustc_passes/src/check_attr.rs
Some changes occurred in compiler/rustc_attr_data_structures
Some changes occurred in compiler/rustc_codegen_ssa
Some changes occurred in compiler/rustc_attr_parsing
Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll sequence this after #142825 which likely needs a rebase anyway. I like the impl, just some minor things.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
^ Rebased & fixed feedback
@rustbot ready
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
📌 Commit 85108ca has been approved by jdonszelmann
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…, r=jdonszelmann
Port #[export_name] to the new attribute parsing infrastructure
This PR contains two changes, in separate commits for reviewability:
- Ports
export_nameto the new attribute parsing infrastructure for rust-lang#131229 (comment) - Moves the check for mixing export_name/no_mangle to check_attr.rs and improve the error message, which previously had a mix of 2021/2024 edition syntax
r? @jdonszelmann
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
^ Fixed the comment above
@rustbot ready
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Will likely fail ci after the merges from yesterday fyi
This comment has been minimized.
Signed-off-by: Jonathan Brouwer jonathantbrouwer@gmail.com
…he error
Signed-off-by: Jonathan Brouwer jonathantbrouwer@gmail.com
Well predicted :P
^ I think that should fix it? Haven't ran the test suite locally because my laptop is a bit underpowered, really miss my desktop at home when I'm in the train
I'll fix the other PRs in a bit
📌 Commit 3d1cee5 has been approved by jdonszelmann
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
This was referenced
Jun 26, 2025
bors added a commit that referenced this pull request
…rors
Rollup of 18 pull requests
Successful merges:
- #137843 (make RefCell unstably const)
- #140942 (const-eval: allow constants to refer to mutable/external memory, but reject such constants as patterns)
- #142549 (small iter.intersperse.fold() optimization)
- #142637 (Remove some glob imports from the type system)
- #142647 ([perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation)
- #142700 (Remove incorrect comments in
Weak) - #142927 (Add note to
find_const_ty_from_env) - #142967 (Fix RwLock::try_write documentation for WouldBlock condition)
- #142986 (Port
#[export_name]to the new attribute parsing infrastructure) - #143001 (Rename run always )
- #143010 (Update
browser-ui-testversion to0.20.7) - #143015 (Add
sym::macro_pindiagnostic item forcore::pin::pin!()) - #143033 (Expand const-stabilized API links in relnotes)
- #143041 (Remove cache for citool)
- #143056 (Move an ACE test out of the GCI directory)
- #143059 (Fix 1.88 relnotes)
- #143067 (Tracking issue number for
iter_macro) - #143073 (Fix some fixmes that were waiting for let chains)
Failed merges:
- #143020 (codegen_fn_attrs: make comment more precise)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #142986 - JonathanBrouwer:export_name_parser, r=jdonszelmann
Port #[export_name] to the new attribute parsing infrastructure
This PR contains two changes, in separate commits for reviewability:
- Ports
export_nameto the new attribute parsing infrastructure for #131229 (comment) - Moves the check for mixing export_name/no_mangle to check_attr.rs and improve the error message, which previously had a mix of 2021/2024 edition syntax
r? @jdonszelmann
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
Labels
Area: Attributes (`#[…]`, `#![…]`)
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the rustdoc team, which will review and decide on the PR/issue.