codegen_fn_attrs: make comment more precise by RalfJung · Pull Request #143020 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits1 Checks10 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

rustbot added A-attributes

Area: Attributes (`#[…]`, `#![…]`)

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jun 25, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs

cc @jdonszelmann

📌 Commit 9d11fd0 has been approved by oli-obk

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 25, 2025

samueltardieu added a commit to samueltardieu/rust that referenced this pull request

Jun 26, 2025

codegen_fn_attrs: make comment more precise

Follow-up to rust-lang#142854.

r? @oli-obk or @workingjubilee

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Jun 26, 2025

codegen_fn_attrs: make comment more precise

Follow-up to rust-lang#142854.

r? @oli-obk or @workingjubilee

bors added a commit that referenced this pull request

Jun 26, 2025

Rollup of 17 pull requests

Successful merges:

#124595 (Suggest cloning Arc moved into closure)
#139594 (Simplify ObligationCauseCode::IfExpression)
#141311 (make tidy-alphabetical use a natural sort)
#141648 ([rustdoc] Do not emit redundant_explicit_links lint if the doc comment comes from expansion)
#142255 (Add edition checks for some tests that had divergent output)
#142285 (tests: Do not run afoul of asm.validity.non-exhaustive in input-stats)
#142549 (small iter.intersperse.fold() optimization)
#142637 (Remove some glob imports from the type system)
#142647 ([perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation)
#142700 (Remove incorrect comments in Weak)
#142884 (StableMIR: Add method to retrieve body of coroutine)
#142925 (Rewrite .gitattributes CRLF ui tests into run-make tests)
#143001 (Rename run always )
#143010 (Update browser-ui-test version to 0.20.7)
#143015 (Add sym::macro_pin diagnostic item for core::pin::pin!())
#143020 (codegen_fn_attrs: make comment more precise)
#143033 (Expand const-stabilized API links in relnotes)

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 26, 2025

codegen_fn_attrs: make comment more precise

Follow-up to rust-lang#142854.

r? @oli-obk or @workingjubilee

compiler-errors added a commit to compiler-errors/rust that referenced this pull request

Jun 26, 2025

codegen_fn_attrs: make comment more precise

Follow-up to rust-lang#142854.

r? @oli-obk or @workingjubilee

This was referenced

Jun 26, 2025

bors added a commit that referenced this pull request

Jun 27, 2025

…rors

Rollup of 18 pull requests

Successful merges:

#137843 (make RefCell unstably const)
#140942 (const-eval: allow constants to refer to mutable/external memory, but reject such constants as patterns)
#142549 (small iter.intersperse.fold() optimization)
#142637 (Remove some glob imports from the type system)
#142647 ([perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation)
#142700 (Remove incorrect comments in Weak)
#142927 (Add note to find_const_ty_from_env)
#142967 (Fix RwLock::try_write documentation for WouldBlock condition)
#142986 (Port #[export_name] to the new attribute parsing infrastructure)
#143001 (Rename run always )
#143010 (Update browser-ui-test version to 0.20.7)
#143015 (Add sym::macro_pin diagnostic item for core::pin::pin!())
#143033 (Expand const-stabilized API links in relnotes)
#143041 (Remove cache for citool)
#143056 (Move an ACE test out of the GCI directory)
#143059 (Fix 1.88 relnotes)
#143067 (Tracking issue number for iter_macro)
#143073 (Fix some fixmes that were waiting for let chains)

Failed merges:

#143020 (codegen_fn_attrs: make comment more precise)

r? @ghost @rustbot modify labels: rollup

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Jun 27, 2025

📌 Commit 18f05eb has been approved by oli-obk

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jun 27, 2025

This comment has been minimized.

📌 Commit 1365d3b has been approved by oli-obk

It is now in the queue for this repository.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Jun 27, 2025

codegen_fn_attrs: make comment more precise

Follow-up to rust-lang#142854.

r? @oli-obk or @workingjubilee

bors added a commit that referenced this pull request

Jun 27, 2025

Rollup of 6 pull requests

Successful merges:

#142270 (Rustdoc js: even more typechecking improvements)
#142420 (Report infer ty errors during hir ty lowering)
#142818 (Port #[used] to new attribute parsing infrastructure)
#143020 (codegen_fn_attrs: make comment more precise)
#143036 (Remove support for dyn* from the compiler)
#143060 (Only args in main diag are saved and restored without removing the newly added ones)

r? @ghost @rustbot modify labels: rollup

bors added a commit that referenced this pull request

Jun 27, 2025

Rollup of 10 pull requests

Successful merges:

#142270 (Rustdoc js: even more typechecking improvements)
#142420 (Report infer ty errors during hir ty lowering)
#142671 (add #![rustc_no_implicit_bounds])
#142721 (Add tracing to InterpCx::layout_of() )
#142818 (Port #[used] to new attribute parsing infrastructure)
#143020 (codegen_fn_attrs: make comment more precise)
#143051 (Add tracing to validate_operand)
#143060 (Only args in main diag are saved and restored without removing the newly added ones)
#143065 (Improve recovery when users write where:)
#143084 (const-eval: error when initializing a static writes to that static)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit that referenced this pull request

Jun 27, 2025

Rollup merge of #143020 - RalfJung:codegen_fn_attrs, r=oli-obk

codegen_fn_attrs: make comment more precise

Follow-up to #142854.

r? @oli-obk or @workingjubilee

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request

Jun 28, 2025

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Jul 4, 2025

Labels

A-attributes

Area: Attributes (`#[…]`, `#![…]`)

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.