Remove incorrect comments in Weak by theemathas · Pull Request #142700 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits1 Checks9 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
It is currently possible to create a dangling Weak to a DST by calling Weak::new() for a sized type, then doing an unsized coercion. Therefore, the comments are wrong.
These comments were added in #73845. As far as I can tell, the guarantee in the comment was only previously used in the as_ptr method. However, the current implementation of as_ptr no longer relies on this guarantee.
It is currently possible to create a dangling Weak to a DST by
calling Weak::new() for a sized type, then doing an unsized coercion.
Therefore, the comments are wrong.
These comments were added in <rust-lang#73845>.
As far as I can tell, the guarantee in the comment was only previously
used in the as_ptr method. However, the current implementation of
as_ptr no longer relies on this guarantee.
r? @ibraheemdev
rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library team, which will review and decide on the PR/issue.
labels
Good catch, thanks. @bors r+ rollup
📌 Commit 644469e has been approved by ibraheemdev
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
samueltardieu added a commit to samueltardieu/rust that referenced this pull request
…ibraheemdev
Remove incorrect comments in Weak
It is currently possible to create a dangling Weak to a DST by calling Weak::new() for a sized type, then doing an unsized coercion. Therefore, the comments are wrong.
These comments were added in <rust-lang#73845>. As far as I can tell, the guarantee in the comment was only previously used in the as_ptr method. However, the current implementation of as_ptr no longer relies on this guarantee.
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…ibraheemdev
Remove incorrect comments in Weak
It is currently possible to create a dangling Weak to a DST by calling Weak::new() for a sized type, then doing an unsized coercion. Therefore, the comments are wrong.
These comments were added in <rust-lang#73845>. As far as I can tell, the guarantee in the comment was only previously used in the as_ptr method. However, the current implementation of as_ptr no longer relies on this guarantee.
bors added a commit that referenced this pull request
Rollup of 17 pull requests
Successful merges:
- #124595 (Suggest cloning
Arcmoved into closure) - #139594 (Simplify
ObligationCauseCode::IfExpression) - #141311 (make
tidy-alphabeticaluse a natural sort) - #141648 ([rustdoc] Do not emit redundant_explicit_links lint if the doc comment comes from expansion)
- #142255 (Add edition checks for some tests that had divergent output)
- #142285 (tests: Do not run afoul of asm.validity.non-exhaustive in input-stats)
- #142549 (small iter.intersperse.fold() optimization)
- #142637 (Remove some glob imports from the type system)
- #142647 ([perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation)
- #142700 (Remove incorrect comments in
Weak) - #142884 (StableMIR: Add method to retrieve body of coroutine)
- #142925 (Rewrite
.gitattributesCRLF ui tests into run-make tests) - #143001 (Rename run always )
- #143010 (Update
browser-ui-testversion to0.20.7) - #143015 (Add
sym::macro_pindiagnostic item forcore::pin::pin!()) - #143020 (codegen_fn_attrs: make comment more precise)
- #143033 (Expand const-stabilized API links in relnotes)
r? @ghost
@rustbot modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…ibraheemdev
Remove incorrect comments in Weak
It is currently possible to create a dangling Weak to a DST by calling Weak::new() for a sized type, then doing an unsized coercion. Therefore, the comments are wrong.
These comments were added in <rust-lang#73845>. As far as I can tell, the guarantee in the comment was only previously used in the as_ptr method. However, the current implementation of as_ptr no longer relies on this guarantee.
compiler-errors added a commit to compiler-errors/rust that referenced this pull request
…ibraheemdev
Remove incorrect comments in Weak
It is currently possible to create a dangling Weak to a DST by calling Weak::new() for a sized type, then doing an unsized coercion. Therefore, the comments are wrong.
These comments were added in <rust-lang#73845>. As far as I can tell, the guarantee in the comment was only previously used in the as_ptr method. However, the current implementation of as_ptr no longer relies on this guarantee.
This was referenced
Jun 26, 2025
bors added a commit that referenced this pull request
…rors
Rollup of 18 pull requests
Successful merges:
- #137843 (make RefCell unstably const)
- #140942 (const-eval: allow constants to refer to mutable/external memory, but reject such constants as patterns)
- #142549 (small iter.intersperse.fold() optimization)
- #142637 (Remove some glob imports from the type system)
- #142647 ([perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation)
- #142700 (Remove incorrect comments in
Weak) - #142927 (Add note to
find_const_ty_from_env) - #142967 (Fix RwLock::try_write documentation for WouldBlock condition)
- #142986 (Port
#[export_name]to the new attribute parsing infrastructure) - #143001 (Rename run always )
- #143010 (Update
browser-ui-testversion to0.20.7) - #143015 (Add
sym::macro_pindiagnostic item forcore::pin::pin!()) - #143033 (Expand const-stabilized API links in relnotes)
- #143041 (Remove cache for citool)
- #143056 (Move an ACE test out of the GCI directory)
- #143059 (Fix 1.88 relnotes)
- #143067 (Tracking issue number for
iter_macro) - #143073 (Fix some fixmes that were waiting for let chains)
Failed merges:
- #143020 (codegen_fn_attrs: make comment more precise)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #142700 - theemathas:remove-weak-comment, r=ibraheemdev
Remove incorrect comments in Weak
It is currently possible to create a dangling Weak to a DST by calling Weak::new() for a sized type, then doing an unsized coercion. Therefore, the comments are wrong.
These comments were added in <#73845>. As far as I can tell, the guarantee in the comment was only previously used in the as_ptr method. However, the current implementation of as_ptr no longer relies on this guarantee.
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
…ibraheemdev
Remove incorrect comments in Weak
It is currently possible to create a dangling Weak to a DST by calling Weak::new() for a sized type, then doing an unsized coercion. Therefore, the comments are wrong.
These comments were added in <rust-lang#73845>. As far as I can tell, the guarantee in the comment was only previously used in the as_ptr method. However, the current implementation of as_ptr no longer relies on this guarantee.
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the library team, which will review and decide on the PR/issue.